Added SQL Server test cases

Cake/Test/TestCase/Database/Driver/SqlserverTest.php

@@ -0,0 +1,85 @@
+<?php
+/**
+ * PHP Version 5.4
+ *
+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ *
+ * Licensed under The MIT License
+ * For full copyright and license information, please see the LICENSE.txt
+ * Redistributions of files must retain the above copyright notice.
+ *
+ * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ * @link          http://cakephp.org CakePHP(tm) Project
+ * @since         CakePHP(tm) v 3.0.0
+ * @license       MIT License (http://www.opensource.org/licenses/mit-license.php)
+ */
+namespace Cake\Test\TestCase\Database\Driver;
+
+use Cake\Core\Configure;
+use Cake\Database\Connection;
+use Cake\Database\Driver\Sqlserver;
+use Cake\Database\Query;
+use \PDO;
+
+/**
+ * Tests Sqlserver driver
+ */
+class SqlserverTest extends \Cake\TestSuite\TestCase {
+
+/**
+ * Test connecting to Sqlserver with custom configuration
+ *
+ * @return void
+ */
+	public function testConnectionConfigCustom() {
+		$config = [
+			'persistent' => false,
+			'host' => 'foo\SQLSERVER',
+			'login' => 'Administrator',
+			'password' => 'blablabla',
+			'database' => 'bar',
+			'encoding' => 'a-language',
+			'flags' => [1 => true, 2 => false],
+			'init' => ['Execute this', 'this too'],
+			'settings' => ['config1' => 'value1', 'config2' => 'value2'],
+		];
+		$driver = $this->getMock(
+			'Cake\Database\Driver\Sqlserver',
+			['_connect', 'connection'],
+			[$config]
+		);
+
+		$expected = $config;
+		$expected['dsn'] = 'sqlsrv:server=foo\SQLSERVER;Database=bar';
+		$expected['flags'] += [
+			PDO::ATTR_PERSISTENT => false,
+			PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
+			PDO::SQLSRV_ATTR_ENCODING => 'a-language'
+		];
+
+		$connection = $this->getMock('stdClass', ['exec', 'quote']);
+		$connection->expects($this->any())
+			->method('quote')
+			->will($this->onConsecutiveCalls(
+				$this->returnArgument(0),
+				$this->returnArgument(0),
+				$this->returnArgument(0)
+			));
+
+		$connection->expects($this->at(1))->method('exec')->with('Execute this');
+		$connection->expects($this->at(2))->method('exec')->with('this too');
+		$connection->expects($this->at(3))->method('exec')->with('SET config1 value1');
+		$connection->expects($this->at(4))->method('exec')->with('SET config2 value2');
+
+		$driver->connection($connection);
+		$driver->expects($this->once())->method('_connect')
+			->with($expected);
+
+		$driver->expects($this->any())->method('connection')
+			->will($this->returnValue($connection));
+
+		$driver->connect();
+	}
+
+}

Cake/Test/TestCase/Database/Schema/SqlserverSchemaTest.php

@@ -0,0 +1,652 @@
+<?php
+/**
+ * PHP Version 5.4
+ *
+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ *
+ * Licensed under The MIT License
+ * For full copyright and license information, please see the LICENSE.txt
+ * Redistributions of files must retain the above copyright notice.
+ *
+ * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+ * @link          http://cakephp.org CakePHP(tm) Project
+ * @since         CakePHP(tm) v 3.0.0
+ * @license       MIT License (http://www.opensource.org/licenses/mit-license.php)
+ */
+namespace Cake\Test\TestCase\Database\Schema;
+
+use Cake\Core\Configure;
+use Cake\Database\ConnectionManager;
+use Cake\Database\Schema\Collection as SchemaCollection;
+use Cake\Database\Schema\SqlserverSchema;
+use Cake\Database\Schema\Table;
+use Cake\TestSuite\TestCase;
+
+/**
+ * SQL Server schema test case.
+ */
+class SqlserverSchemaTest extends TestCase {
+
+/**
+ * Helper method for skipping tests that need a real connection.
+ *
+ * @return void
+ */
+	protected function _needsConnection() {
+		$config = ConnectionManager::config('test');
+		$this->skipIf(strpos($config['className'], 'Sqlserver') === false, 'Not using Sqlserver for test config');
+	}
+
+/**
+ * Helper method for testing methods.
+ *
+ * @return void
+ */
+	protected function _createTables($connection) {
+		$this->_needsConnection();
+
+		$connection->execute("IF OBJECT_ID('dbo.Scores', 'U') IS NOT NULL DROP TABLE schema_articles");
+		$connection->execute("IF OBJECT_ID('dbo.Scores', 'U') IS NOT NULL DROP TABLE schema_authors");
+
+		$table = <<<SQL
+CREATE TABLE schema_authors (
+id int IDENTITY(1,1) PRIMARY KEY,
+name VARCHAR(50),
+bio DATE,
+created DATETIME
+)
+SQL;
+		$connection->execute($table);
+
+		$table = <<<SQL
+CREATE TABLE schema_articles (
+id BIGINT PRIMARY KEY,
+title VARCHAR(20),
+body TEXT,
+author_id INTEGER NOT NULL,
+published BOOLEAN DEFAULT false,
+views SMALLINT DEFAULT 0,
+created DATETIME,
+CONSTRAINT [content_idx] UNIQUE ([title], [body]),
+CONSTRAINT [author_idx] FOREIGN KEY ([author_id]) REFERENCES [schema_authors] ([id]) ON DELETE SET DEFAULT ON UPDATE CASCADE
+)
+SQL;
+		$connection->execute($table);
+		$connection->execute('CREATE INDEX [author_idx] ON [schema_articles] ([author_id])');
+	}
+
+/**
+ * Data provider for convert column testing
+ *
+ * @return array
+ */
+	public static function convertColumnProvider() {
+		return [
+			[
+				'DATETIME',
+				['type' => 'datetime', 'length' => null]
+			],
+			[
+				'DATE',
+				['type' => 'date', 'length' => null]
+			],
+			[
+				'TIME',
+				['type' => 'time', 'length' => null]
+			],
+			[
+				'SMALLINT',
+				['type' => 'integer', 'length' => 5]
+			],
+			[
+				'INTEGER',
+				['type' => 'integer', 'length' => 10]
+			],
+			[
+				'BIGINT',
+				['type' => 'biginteger', 'length' => 20]
+			],
+			[
+				'NUMERIC',
+				['type' => 'decimal', 'length' => null]
+			],
+			[
+				'DECIMAL(10,2)',
+				['type' => 'decimal', 'length' => null]
+			],
+			[
+				'MONEY',
+				['type' => 'decimal', 'length' => null]
+			],
+			[
+				'VARCHAR',
+				['type' => 'string', 'length' => null]
+			],
+			[
+				'VARCHAR(10)',
+				['type' => 'string', 'length' => 10]
+			],
+			[
+				'CHAR(10)',
+				['type' => 'string', 'fixed' => true, 'length' => 10]
+			],
+			[
+				'UNIQUEIDENTIFIER',
+				['type' => 'string', 'fixed' => true, 'length' => 36]
+			],
+			[
+				'TEXT',
+				['type' => 'text', 'length' => null]
+			],
+			[
+				'REAL',
+				['type' => 'float', 'length' => null]
+			],
+		];
+	}
+
+/**
+ * Test parsing Postgres column types from field description.
+ *
+ * @dataProvider convertColumnProvider
+ * @return void
+ */
+	public function testConvertColumn($type, $expected) {
+		$field = [
+			'name' => 'field',
+			'type' => $type,
+			'null' => 'YES',
+			'default' => 'Default value',
+			'char_length' => null,
+		];
+		$expected += [
+			'null' => true,
+			'default' => 'Default value',
+		];
+
+		$driver = $this->getMock('Cake\Database\Driver\Sqlserver');
+		$dialect = new SqlserverSchema($driver);
+
+		$table = $this->getMock('Cake\Database\Schema\Table', [], ['table']);
+		$table->expects($this->at(0))->method('addColumn')->with('field', $expected);
+
+		$dialect->convertFieldDescription($table, $field);
+	}
+
+/**
+ * Test listing tables with Postgres
+ *
+ * @return void
+ */
+	public function testListTables() {
+		$connection = ConnectionManager::get('test');
+		$this->_createTables($connection);
+
+		$schema = new SchemaCollection($connection);
+		$result = $schema->listTables();
+		$this->assertInternalType('array', $result);
+		$this->assertCount(2, $result);
+		$this->assertEquals('schema_articles', $result[0]);
+		$this->assertEquals('schema_authors', $result[1]);
+	}
+
+/**
+ * Test describing a table with Postgres
+ *
+ * @return void
+ */
+	public function testDescribeTable() {
+		$connection = ConnectionManager::get('test');
+		$this->_createTables($connection);
+
+		$schema = new SchemaCollection($connection);
+		$result = $schema->describe('schema_articles');
+		$expected = [
+			'id' => [
+				'type' => 'biginteger',
+				'null' => false,
+				'default' => null,
+				'length' => 20,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+			'title' => [
+				'type' => 'string',
+				'null' => true,
+				'default' => null,
+				'length' => 20,
+				'precision' => null,
+				'comment' => 'a title',
+				'fixed' => null,
+			],
+			'body' => [
+				'type' => 'text',
+				'null' => true,
+				'default' => null,
+				'length' => null,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+			'author_id' => [
+				'type' => 'integer',
+				'null' => false,
+				'default' => null,
+				'length' => 10,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+			'published' => [
+				'type' => 'boolean',
+				'null' => true,
+				'default' => 0,
+				'length' => null,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+			'views' => [
+				'type' => 'integer',
+				'null' => true,
+				'default' => 0,
+				'length' => 5,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+			'created' => [
+				'type' => 'datetime',
+				'null' => true,
+				'default' => null,
+				'length' => null,
+				'precision' => null,
+				'fixed' => null,
+				'comment' => null,
+			],
+		];
+		$this->assertEquals(['id'], $result->primaryKey());
+		foreach ($expected as $field => $definition) {
+			$this->assertEquals($definition, $result->column($field));
+		}
+	}
+
+/**
+ * Test describing a table with indexes
+ *
+ * @return void
+ */
+	public function testDescribeTableIndexes() {
+		$connection = ConnectionManager::get('test');
+		$this->_createTables($connection);
+
+		$schema = new SchemaCollection($connection);
+		$result = $schema->describe('schema_articles');
+		$this->assertInstanceOf('Cake\Database\Schema\Table', $result);
+		$expected = [
+			'primary' => [
+				'type' => 'primary',
+				'columns' => ['id'],
+				'length' => []
+			],
+			'content_idx' => [
+				'type' => 'unique',
+				'columns' => ['title', 'body'],
+				'length' => []
+			]
+		];
+		$this->assertCount(3, $result->constraints());
+		$expected = [
+			'primary' => [
+				'type' => 'primary',
+				'columns' => ['id'],
+				'length' => []
+			],
+			'content_idx' => [
+				'type' => 'unique',
+				'columns' => ['title', 'body'],
+				'length' => []
+			],
+			'author_idx' => [
+				'type' => 'foreign',
+				'columns' => ['author_id'],
+				'references' => ['schema_authors', 'id'],
+				'length' => [],
+				'update' => 'cascade',
+				'delete' => 'setDefault',
+			]
+		];
+		$this->assertEquals($expected['primary'], $result->constraint('primary'));
+		$this->assertEquals($expected['content_idx'], $result->constraint('content_idx'));
+		$this->assertEquals($expected['author_idx'], $result->constraint('author_idx'));
+
+		$this->assertCount(1, $result->indexes());
+		$expected = [
+			'type' => 'index',
+			'columns' => ['author_id'],
+			'length' => []
+		];
+		$this->assertEquals($expected, $result->index('author_idx'));
+	}
+
+/**
+ * Column provider for creating column sql
+ *
+ * @return array
+ */
+	public static function columnSqlProvider() {
+		return [
+			// strings
+			[
+				'title',
+				['type' => 'string', 'length' => 25, 'null' => false],
+				'[title] VARCHAR(25) NOT NULL'
+			],
+			[
+				'title',
+				['type' => 'string', 'length' => 25, 'null' => true, 'default' => 'ignored'],
+				'[title] VARCHAR(25) DEFAULT NULL'
+			],
+			[
+				'id',
+				['type' => 'string', 'length' => 32, 'fixed' => true, 'null' => false],
+				'[id] CHAR(32) NOT NULL'
+			],
+			[
+				'id',
+				['type' => 'string', 'length' => 36, 'fixed' => true, 'null' => false],
+				'[id] UNIQUEIDENTIFIER NOT NULL'
+			],
+			[
+				'role',
+				['type' => 'string', 'length' => 10, 'null' => false, 'default' => 'admin'],
+				"[role] VARCHAR(10) NOT NULL DEFAULT 'admin'"
+			],
+			[
+				'title',
+				['type' => 'string'],
+				'[title] VARCHAR'
+			],
+			// Text
+			[
+				'body',
+				['type' => 'text', 'null' => false],
+				'[body] TEXT NOT NULL'
+			],
+			// Integers
+			[
+				'post_id',
+				['type' => 'integer', 'length' => 11],
+				'[post_id] INTEGER'
+			],
+			[
+				'post_id',
+				['type' => 'biginteger', 'length' => 20],
+				'[post_id] BIGINT'
+			],
+			// Decimal
+			[
+				'value',
+				['type' => 'decimal'],
+				'[value] DECIMAL'
+			],
+			[
+				'value',
+				['type' => 'decimal', 'length' => 11],
+				'[value] DECIMAL(11,0)'
+			],
+			[
+				'value',
+				['type' => 'decimal', 'length' => 12, 'precision' => 5],
+				'[value] DECIMAL(12,5)'
+			],
+			// Float
+			[
+				'value',
+				['type' => 'float'],
+				'[value] FLOAT'
+			],
+			[
+				'value',
+				['type' => 'float', 'length' => 11, 'precision' => 3],
+				'[value] FLOAT(3)'
+			],
+			// Binary
+			[
+				'img',
+				['type' => 'binary'],
+				'[img] BINARY'
+			],
+			// Boolean
+			[
+				'checked',
+				['type' => 'boolean', 'default' => false],
+				'[checked] BOOLEAN DEFAULT FALSE'
+			],
+			[
+				'checked',
+				['type' => 'boolean', 'default' => true, 'null' => false],
+				'[checked] BOOLEAN NOT NULL DEFAULT TRUE'
+			],
+			// datetimes
+			[
+				'created',
+				['type' => 'datetime'],
+				'[created] DATETIME'
+			],
+			// Date & Time
+			[
+				'start_date',
+				['type' => 'date'],
+				'[start_date] DATE'
+			],
+			[
+				'start_time',
+				['type' => 'time'],
+				'[start_time] TIME'
+			],
+			// timestamps
+			[
+				'created',
+				['type' => 'timestamp', 'null' => true],
+				'[created] DATETIME DEFAULT NULL'
+			],
+		];
+	}
+
+/**
+ * Test generating column definitions
+ *
+ * @dataProvider columnSqlProvider
+ * @return void
+ */
+	public function testColumnSql($name, $data, $expected) {
+		$driver = $this->_getMockedDriver();
+		$schema = new SqlserverSchema($driver);
+
+		$table = (new Table('schema_articles'))->addColumn($name, $data);
+		$this->assertEquals($expected, $schema->columnSql($table, $name));
+	}
+
+/**
+ * Provide data for testing constraintSql
+ *
+ * @return array
+ */
+	public static function constraintSqlProvider() {
+		return [
+			[
+				'primary',
+				['type' => 'primary', 'columns' => ['title']],
+				'PRIMARY KEY ([title])'
+			],
+			[
+				'unique_idx',
+				['type' => 'unique', 'columns' => ['title', 'author_id']],
+				'CONSTRAINT [unique_idx] UNIQUE ([title], [author_id])'
+			],
+			[
+				'author_id_idx',
+				['type' => 'foreign', 'columns' => ['author_id'], 'references' => ['authors', 'id']],
+				'CONSTRAINT [author_id_idx] FOREIGN KEY ([author_id]) ' .
+				'REFERENCES [authors] ([id]) ON UPDATE SET NULL ON DELETE SET NULL'
+			],
+			[
+				'author_id_idx',
+				['type' => 'foreign', 'columns' => ['author_id'], 'references' => ['authors', 'id'], 'update' => 'cascade'],
+				'CONSTRAINT [author_id_idx] FOREIGN KEY ([author_id]) ' .
+				'REFERENCES [authors] ([id]) ON UPDATE CASCADE ON DELETE SET NULL'
+			],
+			[
+				'author_id_idx',
+				['type' => 'foreign', 'columns' => ['author_id'], 'references' => ['authors', 'id'], 'update' => 'setDefault'],
+				'CONSTRAINT [author_id_idx] FOREIGN KEY ([author_id]) ' .
+				'REFERENCES [authors] ([id]) ON UPDATE SET NULL ON DELETE SET DEFAULT'
+			],
+			[
+				'author_id_idx',
+				['type' => 'foreign', 'columns' => ['author_id'], 'references' => ['authors', 'id'], 'update' => 'setNull'],
+				'CONSTRAINT [author_id_idx] FOREIGN KEY ([author_id]) ' .
+				'REFERENCES [authors] ([id]) ON UPDATE SET NULL ON DELETE SET NULL'
+			],
+			[
+				'author_id_idx',
+				['type' => 'foreign', 'columns' => ['author_id'], 'references' => ['authors', 'id'], 'update' => 'noAction'],
+				'CONSTRAINT [author_id_idx] FOREIGN KEY ([author_id]) ' .
+				'REFERENCES [authors] ([id]) ON UPDATE NO ACTION ON DELETE SET NULL'
+			],
+		];
+	}
+
+/**
+ * Test the constraintSql method.
+ *
+ * @dataProvider constraintSqlProvider
+ */
+	public function testConstraintSql($name, $data, $expected) {
+		$driver = $this->_getMockedDriver();
+		$schema = new SqlserverSchema($driver);
+
+		$table = (new Table('schema_articles'))->addColumn('title', [
+			'type' => 'string',
+			'length' => 255
+		])->addColumn('author_id', [
+			'type' => 'integer',
+		])->addConstraint($name, $data);
+
+		$this->assertEquals($expected, $schema->constraintSql($table, $name));
+	}
+
+/**
+ * Integration test for converting a Schema\Table into MySQL table creates.
+ *
+ * @return void
+ */
+	public function testCreateSql() {
+		$driver = $this->_getMockedDriver();
+		$connection = $this->getMock('Cake\Database\Connection', [], [], '', false);
+		$connection->expects($this->any())->method('driver')
+			->will($this->returnValue($driver));
+
+		$table = (new Table('schema_articles'))->addColumn('id', [
+				'type' => 'integer',
+				'null' => false
+			])
+			->addColumn('title', [
+				'type' => 'string',
+				'null' => false,
+			])
+			->addColumn('body', ['type' => 'text'])
+			->addColumn('created', 'datetime')
+			->addConstraint('primary', [
+				'type' => 'primary',
+				'columns' => ['id'],
+			])
+			->addIndex('title_idx', [
+				'type' => 'index',
+				'columns' => ['title'],
+			]);
+
+		$expected = <<<SQL
+CREATE TABLE [schema_articles] (
+[id] SERIAL,
+[title] VARCHAR NOT NULL,
+[body] TEXT,
+[created] DATETIME,
+PRIMARY KEY ([id])
+)
+SQL;
+		$result = $table->createSql($connection);
+
+		$this->assertCount(2, $result);
+		$this->assertEquals($expected, $result[0]);
+		$this->assertEquals(
+			'CREATE INDEX [title_idx] ON [schema_articles] ([title])',
+			$result[1]
+		);
+	}
+
+/**
+ * test dropSql
+ *
+ * @return void
+ */
+	public function testDropSql() {
+		$driver = $this->_getMockedDriver();
+		$connection = $this->getMock('Cake\Database\Connection', [], [], '', false);
+		$connection->expects($this->any())->method('driver')
+			->will($this->returnValue($driver));
+
+		$table = new Table('schema_articles');
+		$result = $table->dropSql($connection);
+		$this->assertCount(1, $result);
+		$this->assertEquals('DROP TABLE [schema_articles]', $result[0]);
+	}
+
+/**
+ * Test truncateSql()
+ *
+ * @return void
+ */
+	public function testTruncateSql() {
+		$driver = $this->_getMockedDriver();
+		$connection = $this->getMock('Cake\Database\Connection', [], [], '', false);
+		$connection->expects($this->any())->method('driver')
+			->will($this->returnValue($driver));
+
+		$table = new Table('schema_articles');
+		$table->addColumn('id', 'integer')
+			->addConstraint('primary', [
+				'type' => 'primary',
+				'columns' => ['id']
+			]);
+		$result = $table->truncateSql($connection);
+		$this->assertCount(1, $result);
+		$this->assertEquals('TRUNCATE TABLE [schema_articles]', $result[0]);
+	}
+
+/**
+ * Get a schema instance with a mocked driver/pdo instances
+ *
+ * @return Driver
+ */
+	protected function _getMockedDriver() {
+		$driver = new \Cake\Database\Driver\Postgres();
+		$mock = $this->getMock('FakePdo', ['quote', 'quoteIdentifier']);
+		$mock->expects($this->any())
+			->method('quote')
+			->will($this->returnCallback(function ($value) {
+				return '[' . $value . ']';
+			}));
+		$mock->expects($this->any())
+			->method('quoteIdentifier')
+			->will($this->returnCallback(function ($value) {
+				return '[' . $value . ']';
+			}));
+		$driver->connection($mock);
+		return $driver;
+	}
+
+}