Browse Source

Merge pull request #17934 from cakephp/issue-17933

Remove uneeded javascript
Mark Story 1 year ago
parent
commit
096dc94000

+ 2 - 2
src/View/Helper/PaginatorHelper.php

@@ -74,9 +74,9 @@ class PaginatorHelper extends Helper
         'options' => [],
         'templates' => [
             'nextActive' => '<li class="next"><a rel="next" href="{{url}}">{{text}}</a></li>',
-            'nextDisabled' => '<li class="next disabled"><a href="" onclick="return false;">{{text}}</a></li>',
+            'nextDisabled' => '<li class="next disabled"><a>{{text}}</a></li>',
             'prevActive' => '<li class="prev"><a rel="prev" href="{{url}}">{{text}}</a></li>',
-            'prevDisabled' => '<li class="prev disabled"><a href="" onclick="return false;">{{text}}</a></li>',
+            'prevDisabled' => '<li class="prev disabled"><a>{{text}}</a></li>',
             'counterRange' => '{{start}} - {{end}} of {{count}}',
             'counterPages' => '{{page}} of {{pages}}',
             'first' => '<li class="first"><a href="{{url}}">{{text}}</a></li>',

+ 4 - 4
tests/TestCase/View/Helper/PaginatorHelperTest.php

@@ -1092,7 +1092,7 @@ class PaginatorHelperTest extends TestCase
         $result = $this->Paginator->prev('<< Previous');
         $expected = [
             'li' => ['class' => 'prev disabled'],
-            'a' => ['href' => '', 'onclick' => 'return false;'],
+            'a' => [],
             '&lt;&lt; Previous',
             '/a',
             '/li',
@@ -1102,7 +1102,7 @@ class PaginatorHelperTest extends TestCase
         $result = $this->Paginator->prev('<< Previous', ['disabledTitle' => 'Prev']);
         $expected = [
             'li' => ['class' => 'prev disabled'],
-            'a' => ['href' => '', 'onclick' => 'return false;'],
+            'a' => [],
             'Prev',
             '/a',
             '/li',
@@ -1220,7 +1220,7 @@ class PaginatorHelperTest extends TestCase
         $result = $this->Paginator->next('Next >>');
         $expected = [
             'li' => ['class' => 'next disabled'],
-            'a' => ['href' => '', 'onclick' => 'return false;'],
+            'a' => [],
             'Next &gt;&gt;',
             '/a',
             '/li',
@@ -1230,7 +1230,7 @@ class PaginatorHelperTest extends TestCase
         $result = $this->Paginator->next('Next >>', ['disabledTitle' => 'Next']);
         $expected = [
             'li' => ['class' => 'next disabled'],
-            'a' => ['href' => '', 'onclick' => 'return false;'],
+            'a' => [],
             'Next',
             '/a',
             '/li',