Browse Source

Givning in and just using Configure directly in Request::createFromGloabals()

This is the simplest and most understandable that does not disrupt the
application bootstrap entirely
Jose Lorenzo Rodriguez 12 years ago
parent
commit
0cc2c24bef

+ 1 - 1
src/Network/Request.php

@@ -164,7 +164,7 @@ class Request implements \ArrayAccess {
 			'environment' => $_SERVER + $_ENV,
 			'base' => $base,
 			'webroot' => $webroot,
-			'session' => null
+			'session' => Session::create(Configure::read('Session'))
 		);
 		$config['url'] = static::_url($config);
 		return new static($config);

+ 3 - 0
tests/TestCase/Network/RequestTest.php

@@ -2260,6 +2260,9 @@ XML;
 		$session = new Session;
 		$request = new Request(['session' => $session]);
 		$this->assertSame($session, $request->session());
+
+		$request = Request::createFromGlobals();
+		$this->assertEquals($session, $request->session());
 	}
 
 /**

+ 1 - 1
tests/TestCase/Network/SessionTest.php

@@ -437,7 +437,7 @@ class SessionTest extends TestCase {
 			'timeout' => 400,
 		];
 
-		$session = new Session($config);
+		new Session($config);
 		$this->assertEquals(400 * 60, ini_get('session.cookie_lifetime'));
 		$this->assertEquals(400 * 60, ini_get('session.gc_maxlifetime'));
 	}