Browse Source

Revert cookie collection setter.

Robert Pustułka 8 years ago
parent
commit
19935c0447
2 changed files with 6 additions and 35 deletions
  1. 3 28
      src/Http/Client.php
  2. 3 7
      tests/TestCase/Http/ClientTest.php

+ 3 - 28
src/Http/Client.php

@@ -16,9 +16,8 @@ namespace Cake\Http;
 use Cake\Core\App;
 use Cake\Core\Exception\Exception;
 use Cake\Core\InstanceConfigTrait;
-use Cake\Http\Client\CookieCollection as ClientCookieCollection;
+use Cake\Http\Client\CookieCollection;
 use Cake\Http\Client\Request;
-use Cake\Http\Cookie\CookieCollection;
 use Cake\Utility\Hash;
 
 /**
@@ -169,15 +168,14 @@ class Client
             $this->_cookies = $this->_config['cookieJar'];
             $this->setConfig('cookieJar', null);
         } else {
-            $this->_cookies = new ClientCookieCollection();
+            $this->_cookies = new CookieCollection();
         }
     }
 
     /**
      * Get the cookies stored in the Client.
      *
-     * @return \Cake\Http\Cookie\CookieCollection
-     * @deprecated 3.5.0 Use getCookies() instead.
+     * @return \Cake\Http\Client\CookieCollection
      */
     public function cookies()
     {
@@ -185,29 +183,6 @@ class Client
     }
 
     /**
-     * Get the cookies stored in the Client.
-     *
-     * @return \Cake\Http\Cookie\CookieCollection
-     */
-    public function getCookies()
-    {
-        return $this->_cookies;
-    }
-
-    /**
-     * Sets the cookie collection.
-     *
-     * @param \Cake\Http\Cookie\CookieCollection $cookies Cookie collection to be set.
-     * @return $this
-     */
-    public function setCookies(CookieCollection $cookies)
-    {
-        $this->_cookies = $cookies;
-
-        return $this;
-    }
-
-    /**
      * Do a GET request.
      *
      * The $data argument supports a special `_content` key

+ 3 - 7
tests/TestCase/Http/ClientTest.php

@@ -622,22 +622,18 @@ class ClientTest extends TestCase
     }
 
     /**
-     * Test cookie collection getter and setter,
+     * Test cookieJar config option.
      *
      * @return void
      */
-    public function testCookies()
+    public function testCookieJar()
     {
         $jar = new CookieCollection();
         $http = new Client([
             'cookieJar' => $jar
         ]);
 
-        $this->assertSame($jar, $http->getCookies());
-
-        $cookies = new CookieCollection();
-        $http->setCookies($cookies);
-        $this->assertSame($cookies, $http->getCookies());
+        $this->assertSame($jar, $http->cookies());
     }
 
     /**