Browse Source

Write Some Assertions for Validation Library (#10582)

Add additional test coverage for validation methods.
Sohel Rana 9 years ago
parent
commit
2c30c3f329
1 changed files with 7 additions and 0 deletions
  1. 7 0
      tests/TestCase/Validation/ValidationTest.php

+ 7 - 0
tests/TestCase/Validation/ValidationTest.php

@@ -168,6 +168,7 @@ class ValidationTest extends TestCase
 
         $this->assertFalse(Validation::lengthBetween('abcdefg', 1, 6));
         $this->assertFalse(Validation::lengthBetween('ÆΔΩЖÇ', 1, 3));
+        $this->assertFalse(Validation::lengthBetween(1, 1, 3));
     }
 
     /**
@@ -619,6 +620,8 @@ class ValidationTest extends TestCase
         $this->assertTrue(Validation::cc('869958670174621', ['voyager']));
         $this->assertTrue(Validation::cc('869921250068209', ['voyager']));
         $this->assertTrue(Validation::cc('869972521242198', ['voyager']));
+        //Credit card number should not pass as array
+        $this->assertFalse(Validation::cc(['869972521242198'], ['voyager']));
     }
 
     /**
@@ -1960,6 +1963,7 @@ class ValidationTest extends TestCase
         $this->assertFalse(Validation::email('abc@yahoo!.com'));
         $this->assertFalse(Validation::email('abc@example_underscored.com'));
         $this->assertFalse(Validation::email('raw@test.ra.ru....com'));
+        $this->assertFalse(Validation::email(1));
     }
 
     /**
@@ -2813,6 +2817,9 @@ class ValidationTest extends TestCase
         $this->assertFalse(Validation::containsNonAlphaNumeric('abcdef##', 3));
         $this->assertFalse(Validation::containsNonAlphaNumeric('abc##def', 3));
         $this->assertFalse(Validation::containsNonAlphaNumeric('ab#cd#ef', 3));
+
+        //Non alpha numeric should not pass as array
+        $this->assertFalse(Validation::containsNonAlphaNumeric(['abc#']));
     }
 
     /**