Harden CORS origin handling.

The non quoted dots, and the missing beginning/ending delimiters
allow to bypass restrictions when domains are allowed via
`*.good.com`, as the dots will match any char, allowing
for example `not-good.com` to slip through, and the domain name
could also be a subdomain of a different domain, like
`www.good.com.bad.com`.

src/Network/Response.php

@@ -1390,9 +1390,9 @@ class Response
 
             $original = $preg = $domain;
             if (strpos($domain, '://') === false) {
-                $preg = ($requestIsSSL ? 'https://' : 'http://') . $domain;
+                $domain = ($requestIsSSL ? 'https://' : 'http://') . $domain;
             }
-            $preg = '@' . str_replace('*', '.*', $domain) . '@';
+            $preg = '@^' . str_replace('\*', '.*', preg_quote($domain, '@')) . '$@';
             $result[] = compact('original', 'preg');
         }
         return $result;

tests/TestCase/Network/ResponseTest.php

@@ -1113,11 +1113,14 @@ class ResponseTest extends TestCase
     {
         $fooRequest = new Request();
 
-        $secureRequest = $this->getMock('Cake\Network\Request', ['is']);
-        $secureRequest->expects($this->any())
-            ->method('is')
-            ->with('ssl')
-            ->will($this->returnValue(true));
+        $secureRequest = function () {
+            $secureRequest = $this->getMock('Cake\Network\Request', ['is']);
+            $secureRequest->expects($this->any())
+                ->method('is')
+                ->with('ssl')
+                ->will($this->returnValue(true));
+            return $secureRequest;
+        };
 
         return [
             [$fooRequest, null, '*', '', '', false, false],
@@ -1129,9 +1132,15 @@ class ResponseTest extends TestCase
             [$fooRequest, 'http://www.foo.com', 'https://*.foo.com', '', '', false, false],
             [$fooRequest, 'http://www.foo.com', ['*.bar.com', '*.foo.com'], '', '', 'http://www.foo.com', false],
 
-            [$secureRequest, 'https://www.bar.com', 'www.bar.com', '', '', 'https://www.bar.com', false],
-            [$secureRequest, 'https://www.bar.com', 'http://www.bar.com', '', '', false, false],
-            [$secureRequest, 'https://www.bar.com', '*.bar.com', '', '', 'https://www.bar.com', false],
+            [$fooRequest, 'http://not-foo.com', '*.foo.com', '', '', false, false],
+            [$fooRequest, 'http://bad.academy', '*.acad.my', '', '', false, false],
+            [$fooRequest, 'http://www.foo.com.at.bad.com', '*.foo.com', '', '', false, false],
+            [$fooRequest, 'https://www.foo.com', '*.foo.com', '', '', false, false],
+
+            [$secureRequest(), 'https://www.bar.com', 'www.bar.com', '', '', 'https://www.bar.com', false],
+            [$secureRequest(), 'https://www.bar.com', 'http://www.bar.com', '', '', false, false],
+            [$secureRequest(), 'https://www.bar.com', '*.bar.com', '', '', 'https://www.bar.com', false],
+            [$secureRequest(), 'http://www.bar.com', '*.bar.com', '', '', false, false],
 
             [$fooRequest, 'http://www.foo.com', '*', 'GET', '', '*', 'GET'],
             [$fooRequest, 'http://www.foo.com', '*.foo.com', 'GET', '', 'http://www.foo.com', 'GET'],