Remove support for reading ini files with .php extensions.

Instead of relying on this feature one should ensure proper webserver config
so that config files are not web accessible.

src/Core/Configure/Engine/IniConfig.php

@@ -205,17 +205,11 @@ class IniConfig implements ConfigEngineInterface {
  * @return string Full file path
  */
 	protected function _getFilePath($key) {
-		if (substr($key, -8) === '.ini.php') {
-			$key = substr($key, 0, -8);
-			list($plugin, $key) = pluginSplit($key);
-			$key .= '.ini.php';
-		} else {
-			if (substr($key, -4) === '.ini') {
-				$key = substr($key, 0, -4);
-			}
-			list($plugin, $key) = pluginSplit($key);
-			$key .= '.ini';
+		if (substr($key, -4) === '.ini') {
+			$key = substr($key, 0, -4);
 		}
+		list($plugin, $key) = pluginSplit($key);
+		$key .= '.ini';
 
 		if ($plugin) {
 			$file = Plugin::configPath($plugin) . $key;

tests/TestCase/Core/Configure/Engine/IniConfigTest.php

@@ -97,20 +97,6 @@ class IniConfigTest extends TestCase {
 	}
 
 /**
- * Test reading acl.ini.php.
- *
- * @return void
- */
-	public function testReadSpecialAclIniPhp() {
-		$engine = new IniConfig($this->path);
-		$config = $engine->read('acl.ini.php');
-
-		$this->assertTrue(isset($config['admin']));
-		$this->assertTrue(isset($config['paul']['groups']));
-		$this->assertEquals('ads', $config['admin']['deny']);
-	}
-
-/**
  * Test without section.
  *
  * @return void
@@ -228,22 +214,6 @@ class IniConfigTest extends TestCase {
 	}
 
 /**
- * Test reading acl.ini.php from plugins.
- *
- * @return void
- */
-	public function testReadPluginSpecialAclIniPhpValue() {
-		Plugin::load('TestPlugin');
-		$engine = new IniConfig($this->path);
-		$result = $engine->read('TestPlugin.acl.ini.php');
-
-		$this->assertTrue(isset($result['admin']));
-		$this->assertTrue(isset($result['paul']['groups']));
-		$this->assertEquals('ads', $result['admin']['deny']);
-		Plugin::unload();
-	}
-
-/**
  * Test dump method.
  *
  * @return void

tests/test_app/Plugin/TestPlugin/config/acl.ini.php

@@ -1,56 +0,0 @@
-;<?php exit() ?>
-; SVN FILE: $Id$
-;/**
-; * Test App Ini Based Acl Config File
-; *
-; * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
-; * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
-; *
-; *  Licensed under The MIT License
-; *  Redistributions of files must retain the above copyright notice.
-; *
-; * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
-; * @link          http://cakephp.org CakePHP(tm) Project
-; * @since         0.10.0
-; * @license       http://www.opensource.org/licenses/mit-license.php MIT License
-; */
-
-;-------------------------------------
-;Users
-;-------------------------------------
-
-[admin]
-groups = administrators
-allow =
-deny = ads
-
-[paul]
-groups = users
-allow =
-deny =
-
-[jenny]
-groups = users
-allow = ads
-deny = images, files
-
-[nobody]
-groups = anonymous
-allow =
-deny =
-
-;-------------------------------------
-;Groups
-;-------------------------------------
-
-[administrators]
-deny =
-allow = posts, comments, images, files, stats, ads
-
-[users]
-allow = posts, comments, images, files
-deny = stats, ads
-
-[anonymous]
-allow =
-deny = posts, comments, images, files, stats, ads

tests/test_app/config/acl.ini.php

@@ -1,56 +0,0 @@
-;<?php exit() ?>
-; SVN FILE: $Id$
-;/**
-; * Test App Ini Based Acl Config File
-; *
-; * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
-; * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
-; *
-; *  Licensed under The MIT License
-; *  Redistributions of files must retain the above copyright notice.
-; *
-; * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
-; * @link          http://cakephp.org CakePHP(tm) Project
-; * @since         0.10.0
-; * @license       http://www.opensource.org/licenses/mit-license.php MIT License
-; */
-
-;-------------------------------------
-;Users
-;-------------------------------------
-
-[admin]
-groups = administrators
-allow =
-deny = ads
-
-[paul]
-groups = users
-allow =
-deny =
-
-[jenny]
-groups = users
-allow = ads
-deny = images, files
-
-[nobody]
-groups = anonymous
-allow =
-deny =
-
-;-------------------------------------
-;Groups
-;-------------------------------------
-
-[administrators]
-deny =
-allow = posts, comments, images, files, stats, ads
-
-[users]
-allow = posts, comments, images, files
-deny = stats, ads
-
-[anonymous]
-allow =
-deny = posts, comments, images, files, stats, ads