Jose Lorenzo Rodriguez 10 years ago
parent
commit
480a1f0920

+ 1 - 1
src/Database/Expression/BetweenExpression.php

@@ -26,8 +26,8 @@ use Cake\Database\ValueBinder;
 class BetweenExpression implements ExpressionInterface, FieldInterface
 {
 
-    use FieldTrait;
     use ExpressionTypeCasterTrait;
+    use FieldTrait;
 
     /**
      * The first value in the expression

+ 2 - 2
src/Database/Expression/Comparison.php

@@ -29,8 +29,8 @@ use Cake\Database\ValueBinder;
 class Comparison implements ExpressionInterface, FieldInterface
 {
 
-    use FieldTrait;
     use ExpressionTypeCasterTrait;
+    use FieldTrait;
 
     /**
      * The value to be used in the right hand side of the operation
@@ -283,7 +283,7 @@ class Comparison implements ExpressionInterface, FieldInterface
      * and all ExpressionInterface objects that could be found in the second
      * position.
      *
-     * @param array|Traversable $values
+     * @param array|Traversable $values The rows to insert
      * @return array
      */
     protected function _collectExpressions($values)

+ 1 - 1
src/Database/Expression/FunctionExpression.php

@@ -31,8 +31,8 @@ use Cake\Database\ValueBinder;
 class FunctionExpression extends QueryExpression implements TypedResultInterface
 {
 
-    use TypedResultTrait;
     use ExpressionTypeCasterTrait;
+    use TypedResultTrait;
 
     /**
      * The name of the function to be constructed when generating the SQL string

+ 1 - 1
src/Database/Expression/ValuesExpression.php

@@ -32,8 +32,8 @@ use Cake\Database\ValueBinder;
 class ValuesExpression implements ExpressionInterface
 {
 
-    use TypeMapTrait;
     use ExpressionTypeCasterTrait;
+    use TypeMapTrait;
 
     /**
      * Array of values to insert.

+ 1 - 1
src/Database/Type/ExpressionTypeCasterTrait.php

@@ -66,7 +66,7 @@ trait ExpressionTypeCasterTrait
      */
     protected function _requiresToExpressionCasting($types)
     {
-        $result  = [];
+        $result = [];
         $types = array_filter($types);
         foreach ($types as $k => $type) {
             $object = Type::build($type);

+ 0 - 1
tests/Fixture/OrderedUuidItemsFixture.php

@@ -43,4 +43,3 @@ class OrderedUuidItemsFixture extends TestFixture
     public $records = [
     ];
 }
-

+ 2 - 2
tests/TestCase/Database/ExpressionTypeCastingIntegrationTest.php

@@ -43,7 +43,7 @@ class OrderedUuidType extends Type implements ExpressionTypeInterface
     public function toExpression($value)
     {
         $substr = function ($start, $lenght = null) use ($value) {
-            return  new FunctionExpression(
+            return new FunctionExpression(
                 'SUBSTR',
                 $lenght === null ? [$value, $start] : [$value, $start, $lenght],
                 ['string', 'integer', 'integer']
@@ -194,7 +194,7 @@ class ExpressionTypeCastingIntegrationTest extends TestCase
             ->select('id')
             ->from('ordered_uuid_items')
             ->where(function ($exp, $q) {
-               return $exp->eq(
+                return $exp->eq(
                     'id',
                     $q->func()->concat(['48298a29-81c0-4c26-a7fb', '-413140cf8569'], []),
                     'ordered_uuid'

+ 8 - 8
tests/TestCase/Database/ExpressionTypeCastingTest.php

@@ -13,16 +13,16 @@
  */
 namespace Cake\Test\TestCase\Database;
 
-use Cake\TestSuite\TestCase;
-use Cake\Database\Type\StringType;
-use Cake\Database\Type\ExpressionTypeInterface;
-use Cake\Database\Expression\FunctionExpression;
-use Cake\Database\ValueBinder;
-use Cake\Database\Type;
-use Cake\Database\Expression\Comparison;
 use Cake\Database\Expression\BetweenExpression;
 use Cake\Database\Expression\CaseExpression;
+use Cake\Database\Expression\Comparison;
+use Cake\Database\Expression\FunctionExpression;
 use Cake\Database\Expression\ValuesExpression;
+use Cake\Database\Type;
+use Cake\Database\Type\ExpressionTypeInterface;
+use Cake\Database\Type\StringType;
+use Cake\Database\ValueBinder;
+use Cake\TestSuite\TestCase;
 
 class TestType extends StringType implements ExpressionTypeInterface
 {
@@ -128,7 +128,7 @@ class ExpressionTypeCastingTest extends TestCase
         $case = new CaseExpression(
             [new Comparison('foo', '1', 'string', '=')],
             ['value1', 'value2'],
-            ['test' , 'test']
+            ['test', 'test']
         );
 
         $binder = new ValueBinder;