Browse Source

Avoding if statements and using `=== null` as nano-optimization

Jose Lorenzo Rodriguez 11 years ago
parent
commit
53a081713d
1 changed files with 3 additions and 10 deletions
  1. 3 10
      src/Controller/Controller.php

+ 3 - 10
src/Controller/Controller.php

@@ -258,17 +258,10 @@ class Controller implements EventListenerInterface
             $this->name = $name;
         }
 
-        if (!($request instanceof Request)) {
-            $request = new Request();
-        }
-        $this->setRequest($request);
-
-        if (!($response instanceof Response)) {
-            $response = new Response();
-        }
-        $this->response = $response;
+        $this->setRequest($request !== null ? $request : new Request);
+        $this->response = $response !== null ? $response : new Response;
 
-        if ($eventManager) {
+        if ($eventManager !== null) {
             $this->eventManager($eventManager);
         }