Browse Source

Fixing last faling test in HHVM.

Moving hhvm out of allowed failures in travis.
Jose Lorenzo Rodriguez 11 years ago
parent
commit
54cb6b38dc
2 changed files with 10 additions and 4 deletions
  1. 1 2
      .travis.yml
  2. 9 2
      tests/TestCase/Error/ExceptionRendererTest.php

+ 1 - 2
.travis.yml

@@ -4,6 +4,7 @@ php:
   - 5.4
   - 5.5
   - 5.6
+  - hhvm-nightly
 
 sudo: false
 
@@ -17,8 +18,6 @@ services:
   - redis-server
 
 matrix:
-  allow_failures:
-    - php: hhvm-nightly
   fast_finish: true
   include:
     - php: 5.4

+ 9 - 2
tests/TestCase/Error/ExceptionRendererTest.php

@@ -137,6 +137,14 @@ class MissingWidgetThingException extends NotFoundException
 }
 
 /**
+ * Exception class for testing app error handlers and custom errors.
+ *
+ */
+class MissingWidgetThing extends \Exception
+{
+}
+
+/**
  * ExceptionRendererTest class
  *
  */
@@ -624,8 +632,7 @@ class ExceptionRendererTest extends TestCase
      */
     public function testExceptionNameMangling()
     {
-        $exception = $this->getMock('Exception', [], ['Bad things', 404], 'MissingWidgetThing');
-        $exceptionRenderer = new MyCustomExceptionRenderer($exception);
+        $exceptionRenderer = new MyCustomExceptionRenderer(new MissingWidgetThing());
 
         $result = $exceptionRenderer->render()->body();
         $this->assertContains('widget thing is missing', $result);