Merge pull request #10536 from Theaxiom/one-time-use

Removing some one-time use variables

src/Auth/BaseAuthenticate.php

@@ -156,9 +156,7 @@ abstract class BaseAuthenticate implements EventListenerInterface
             $options['username'] = $username;
         }
 
-        $query = $table->find($finder, $options);
-
-        return $query;
+        return $table->find($finder, $options);
     }
 
     /**

src/Console/Shell.php

@@ -528,9 +528,8 @@ class Shell
     public function getOptionParser()
     {
         $name = ($this->plugin ? $this->plugin . '.' : '') . $this->name;
-        $parser = new ConsoleOptionParser($name);
 
-        return $parser;
+        return new ConsoleOptionParser($name);
     }
 
     /**

src/Http/Response.php

@@ -1267,9 +1267,8 @@ class Response implements ResponseInterface
             if (!$public && !$private && !$noCache) {
                 return null;
             }
-            $sharable = $public || !($private || $noCache);
 
-            return $sharable;
+            return $public || !($private || $noCache);
         }
         if ($public) {
             $this->_cacheDirectives['public'] = true;

src/ORM/Query.php

@@ -987,9 +987,8 @@ class Query extends DatabaseQuery implements JsonSerializable, QueryInterface
         $this->triggerBeforeFind();
 
         $this->_transformQuery();
-        $sql = parent::sql($binder);
 
-        return $sql;
+        return parent::sql($binder);
     }
 
     /**

src/ORM/Table.php

@@ -2401,9 +2401,8 @@ class Table implements RepositoryInterface, EventListenerInterface, EventDispatc
     {
         if ($data === null) {
             $class = $this->getEntityClass();
-            $entity = new $class([], ['source' => $this->getRegistryAlias()]);
 
-            return $entity;
+            return new $class([], ['source' => $this->getRegistryAlias()]);
         }
         if (!isset($options['associated'])) {
             $options['associated'] = $this->_associations->keys();