Browse Source

add backticks to Debugger::formatHtmlMessage

Kevin Pfeifer 3 years ago
parent
commit
7446f83005
2 changed files with 4 additions and 4 deletions
  1. 1 1
      src/Error/Debugger.php
  2. 3 3
      tests/TestCase/Error/DebuggerTest.php

+ 1 - 1
src/Error/Debugger.php

@@ -793,7 +793,7 @@ class Debugger
     public static function formatHtmlMessage(string $message): string
     {
         $message = h($message);
-        $message = preg_replace('/`([^`]+)`/', '<code>$1</code>', $message);
+        $message = preg_replace('/`([^`]+)`/', '<code>`$1`</code>', $message);
 
         return nl2br($message);
     }

+ 3 - 3
tests/TestCase/Error/DebuggerTest.php

@@ -732,14 +732,14 @@ EXPECTED;
     public function testFormatHtmlMessage(): void
     {
         $output = Debugger::formatHtmlMessage('Some `code` to `replace`');
-        $this->assertSame('Some <code>code</code> to <code>replace</code>', $output);
+        $this->assertSame('Some <code>`code`</code> to <code>`replace`</code>', $output);
 
         $output = Debugger::formatHtmlMessage("Some `co\nde` to `replace`\nmore");
-        $this->assertSame("Some <code>co<br />\nde</code> to <code>replace</code><br />\nmore", $output);
+        $this->assertSame("Some <code>`co<br />\nde`</code> to <code>`replace`</code><br />\nmore", $output);
 
         $output = Debugger::formatHtmlMessage("Some `code` to <script>alert(\"test\")</script>\nmore");
         $this->assertSame(
-            "Some <code>code</code> to &lt;script&gt;alert(&quot;test&quot;)&lt;/script&gt;<br />\nmore",
+            "Some <code>`code`</code> to &lt;script&gt;alert(&quot;test&quot;)&lt;/script&gt;<br />\nmore",
             $output
         );
     }