Browse Source

Fix usage of 'escape' => false.

ADmad 8 years ago
parent
commit
74792f634b
2 changed files with 5 additions and 1 deletions
  1. 1 1
      src/View/Helper/HtmlHelper.php
  2. 4 0
      tests/TestCase/View/Helper/HtmlHelperTest.php

+ 1 - 1
src/View/Helper/HtmlHelper.php

@@ -1096,7 +1096,7 @@ class HtmlHelper extends Helper
      */
     public function para($class, $text, array $options = [])
     {
-        if (isset($options['escape'])) {
+        if (!empty($options['escape'])) {
             $text = h($text);
         }
         if ($class && !empty($class)) {

+ 4 - 0
tests/TestCase/View/Helper/HtmlHelperTest.php

@@ -2055,6 +2055,10 @@ class HtmlHelperTest extends TestCase
         $result = $this->Html->para('class-name', '<text>', ['escape' => true]);
         $expected = ['p' => ['class' => 'class-name'], '&lt;text&gt;', '/p'];
         $this->assertHtml($expected, $result);
+
+        $result = $this->Html->para('class-name', 'text"', ['escape' => false]);
+        $expected = ['p' => ['class' => 'class-name'], 'text"', '/p'];
+        $this->assertHtml($expected, $result);
     }
 
     /**