Browse Source

Code cleanup.

ADmad 6 years ago
parent
commit
a80e4d46fb
4 changed files with 5 additions and 13 deletions
  1. 0 1
      psalm.xml
  2. 2 4
      src/Core/App.php
  3. 2 6
      src/ORM/BehaviorRegistry.php
  4. 1 2
      src/View/ViewBuilder.php

+ 0 - 1
psalm.xml

@@ -17,7 +17,6 @@
     </projectFiles>
 
     <issueHandlers>
-        <LessSpecificReturnType errorLevel="info" />
         <RedundantConditionGivenDocblockType errorLevel="info" />
         <TypeCoercion errorLevel="info" />
         <DocblockTypeContradiction errorLevel="info" />

+ 2 - 4
src/Core/App.php

@@ -65,10 +65,8 @@ class App
         if (static::_classExistsInBase($fullname, $base)) {
             return $base . $fullname;
         }
-        if ($plugin) {
-            return null;
-        }
-        if (!static::_classExistsInBase($fullname, 'Cake')) {
+
+        if ($plugin || !static::_classExistsInBase($fullname, 'Cake')) {
             return null;
         }
 

+ 2 - 6
src/ORM/BehaviorRegistry.php

@@ -88,12 +88,8 @@ class BehaviorRegistry extends ObjectRegistry implements EventDispatcherInterfac
      */
     public static function className(string $class): ?string
     {
-        $result = App::className($class, 'Model/Behavior', 'Behavior');
-        if (!$result) {
-            $result = App::className($class, 'ORM/Behavior', 'Behavior');
-        }
-
-        return $result;
+        return App::className($class, 'Model/Behavior', 'Behavior')
+            ?: App::className($class, 'ORM/Behavior', 'Behavior');
     }
 
     /**

+ 1 - 2
src/View/ViewBuilder.php

@@ -527,8 +527,7 @@ class ViewBuilder implements JsonSerializable, Serializable
         $className = $this->_className;
         if ($className === null) {
             $className = App::className('App', 'View', 'View') ?: View::class;
-        }
-        if ($className === 'View') {
+        } elseif ($className === 'View') {
             $className = App::className($className, 'View');
         } else {
             $className = App::className($className, 'View', 'View');