Merge pull request #17063 from cakephp/5.0-time-constants

Remove unneeded constants.

src/basics.php

@@ -18,14 +18,6 @@ declare(strict_types=1);
 use Cake\Core\Configure;
 use Cake\Error\Debugger;
 
-define('SECOND', 1);
-define('MINUTE', 60);
-define('HOUR', 3600);
-define('DAY', 86400);
-define('WEEK', 604800);
-define('MONTH', 2592000);
-define('YEAR', 31536000);
-
 if (!function_exists('debug')) {
     /**
      * Prints out debug information about given variable and returns the

tests/TestCase/Cache/Engine/FileEngineTest.php

@@ -255,12 +255,12 @@ class FileEngineTest extends TestCase
         $FileOne = new FileEngine();
         $FileOne->init([
             'prefix' => 'prefix_one_',
-            'duration' => DAY,
+            'duration' => 3600,
         ]);
         $FileTwo = new FileEngine();
         $FileTwo->init([
             'prefix' => 'prefix_two_',
-            'duration' => DAY,
+            'duration' => 3600,
         ]);
 
         $dataOne = $dataTwo = $expected = 'content to cache';
@@ -283,7 +283,7 @@ class FileEngineTest extends TestCase
         $engine = new FileEngine();
         $engine->init([
             'prefix' => 'cake_test_',
-            'duration' => DAY,
+            'duration' => 3600,
             'groups' => ['short', 'round'],
         ]);
         $key = 'cake_test_test_key';
@@ -300,7 +300,7 @@ class FileEngineTest extends TestCase
         $engine = new FileEngine();
         $engine->init([
             'prefix' => 'cake_test_',
-            'duration' => DAY,
+            'duration' => 3600,
             'groups' => ['one', 'two'],
         ]);
         $key = 'cake_test_test_key';