Browse Source

remove unused variables/lines

detected by scrutinizer
antograssiot 10 years ago
parent
commit
df6b848389

+ 1 - 1
src/I18n/RelativeTimeFormatter.php

@@ -303,7 +303,7 @@ class RelativeTimeFormatter
         }
 
         $diffData = $this->_diffData($futureTime, $pastTime, $backwards, $options);
-        list($fNum, $fWord, $years, $months, $weeks, $days, $hours, $minutes, $seconds) = array_values($diffData);
+        list($fNum, $fWord, $years, $months, $weeks, $days) = array_values($diffData);
 
         $relativeDate = [];
         if ($fNum >= 1 && $years > 0) {

+ 1 - 1
src/Network/Socket.php

@@ -324,7 +324,7 @@ class Socket
             }
         }
         $totalBytes = strlen($data);
-        for ($written = 0, $rv = 0; $written < $totalBytes; $written += $rv) {
+        for ($written = 0; $written < $totalBytes; $written += $rv) {
             $rv = fwrite($this->connection, substr($data, $written));
             if ($rv === false || $rv === 0) {
                 return $written;

+ 0 - 1
src/ORM/Query.php

@@ -977,7 +977,6 @@ class Query extends DatabaseQuery implements JsonSerializable, QueryInterface
     protected function _addDefaultSelectTypes()
     {
         $typeMap = $this->typeMap()->defaults();
-        $selectTypeMap = $this->selectTypeMap();
         $select = $this->clause('select');
         $types = [];
 

+ 0 - 1
src/TestSuite/TestCase.php

@@ -481,7 +481,6 @@ abstract class TestCase extends PHPUnit_Framework_TestCase
     {
         $asserts = $assertions['attrs'];
         $explains = $assertions['explains'];
-        $len = count($asserts);
         do {
             $matches = false;
             foreach ($asserts as $j => $assert) {

+ 0 - 1
tests/TestCase/View/Helper/HtmlHelperTest.php

@@ -58,7 +58,6 @@ class HtmlHelperTest extends TestCase
     public function setUp()
     {
         parent::setUp();
-        $controller = $this->getMock('Cake\Controller\Controller', ['redirect']);
         $this->View = $this->getMock('Cake\View\View', ['append']);
         $this->Html = new HtmlHelper($this->View);
         $this->Html->request = new Request();