Fixed some issues found by scrutinizer

src/Database/Expression/TupleComparison.php

@@ -29,7 +29,7 @@ class TupleComparison extends Comparison
     /**
      * Constructor
      *
-     * @param string $fields the fields to use to form a tuple
+     * @param string|array $fields the fields to use to form a tuple
      * @param array|ExpressionInterface $values the values to use to form a tuple
      * @param array $types the types names to use for casting each of the values, only
      * one type per position in the value array in needed

src/Database/Query.php

@@ -243,6 +243,9 @@ class Query implements ExpressionInterface, IteratorAggregate
      * real field to be aliased. It is possible to alias strings, Expression objects or
      * even other Query objects.
      *
+     * If a callable function is passed, the returning array of the function will
+     * be used as the list of fields.
+     *
      * By default this function will append any passed argument to the list of fields
      * to be selected, unless the second argument is set to true.
      *
@@ -253,13 +256,16 @@ class Query implements ExpressionInterface, IteratorAggregate
      * $query->select(['author' => 'author_id']); // Appends author: SELECT id, title, author_id as author
      * $query->select('id', true); // Resets the list: SELECT id
      * $query->select(['total' => $countQuery]); // SELECT id, (SELECT ...) AS total
+     * $query->select(function ($query) {
+     *     return ['article_id', 'total' => $query->count('*')];
+     * })
      * ```
      *
      * By default no fields are selected, if you have an instance of `Cake\ORM\Query` and try to append
      * fields you should also call `Cake\ORM\Query::autoFields()` to select the default fields
      * from the table.
      *
-     * @param array|ExpressionInterface|string $fields fields to be added to the list
+     * @param array|ExpressionInterface|string|callable $fields fields to be added to the list.
      * @param bool $overwrite whether to reset fields with passed list or not
      * @return $this
      */
@@ -307,7 +313,8 @@ class Query implements ExpressionInterface, IteratorAggregate
      * $query->distinct('name', true);
      * ```
      *
-     * @param array|ExpressionInterface|string $on fields to be filtered on
+     * @param array|ExpressionInterface|string|boolean $on Enable/disable disctinc class
+     * or list of fields to be filtered on
      * @param bool $overwrite whether to reset fields with passed list or not
      * @return $this
      */

src/ORM/Association/BelongsToMany.php

@@ -434,7 +434,7 @@ class BelongsToMany extends Association
         $bindingKey = (array)$this->bindingKey();
         $conditions = [];
 
-        if ($bindingKey) {
+        if (!empty($bindingKey)) {
             $conditions = array_combine($foreignKey, $entity->extract($bindingKey));
         }
 

src/ORM/EagerLoadable.php

@@ -176,7 +176,7 @@ class EagerLoadable
      * If called with no arguments it returns the current value.
      *
      * @param bool|null $possible The value to set.
-     * @return bool|null
+     * @return bool
      */
     public function canBeJoined($possible = null)
     {
@@ -194,7 +194,7 @@ class EagerLoadable
      * value.
      *
      * @param array|null $config The value to set.
-     * @return array|null
+     * @return array
      */
     public function config(array $config = null)
     {

src/ORM/LazyEagerLoader.php

@@ -126,7 +126,7 @@ class LazyEagerLoader
      * entities.
      *
      * @param array|\Traversable $objects The original list of entities
-     * @param \Cake\Collection\CollectionInterface $results The loaded results
+     * @param \Cake\Collection\CollectionInterface|\Cake\Database\Query $results The loaded results
      * @param array $associations The top level associations that were loaded
      * @param \Cake\ORM\Table $source The table where the entities came from
      * @return array