|
|
@@ -5,10 +5,13 @@
|
|
|
package db
|
|
|
|
|
|
import (
|
|
|
+ "context"
|
|
|
"testing"
|
|
|
"time"
|
|
|
|
|
|
+ mockrequire "github.com/derision-test/go-mockgen/testutil/require"
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
+ "github.com/stretchr/testify/require"
|
|
|
"gorm.io/gorm"
|
|
|
|
|
|
"gogs.io/gogs/internal/auth"
|
|
|
@@ -31,9 +34,7 @@ func TestLoginSource_BeforeSave(t *testing.T) {
|
|
|
t.Run("Config has not been set", func(t *testing.T) {
|
|
|
s := &LoginSource{}
|
|
|
err := s.BeforeSave(db)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Empty(t, s.Config)
|
|
|
})
|
|
|
|
|
|
@@ -44,9 +45,7 @@ func TestLoginSource_BeforeSave(t *testing.T) {
|
|
|
}),
|
|
|
}
|
|
|
err := s.BeforeSave(db)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Equal(t, `{"ServiceName":"pam_service"}`, s.Config)
|
|
|
})
|
|
|
}
|
|
|
@@ -93,20 +92,18 @@ func Test_loginSources(t *testing.T) {
|
|
|
name string
|
|
|
test func(*testing.T, *loginSources)
|
|
|
}{
|
|
|
- {"Create", test_loginSources_Create},
|
|
|
- {"Count", test_loginSources_Count},
|
|
|
- {"DeleteByID", test_loginSources_DeleteByID},
|
|
|
- {"GetByID", test_loginSources_GetByID},
|
|
|
- {"List", test_loginSources_List},
|
|
|
- {"ResetNonDefault", test_loginSources_ResetNonDefault},
|
|
|
- {"Save", test_loginSources_Save},
|
|
|
+ {"Create", loginSourcesCreate},
|
|
|
+ {"Count", loginSourcesCount},
|
|
|
+ {"DeleteByID", loginSourcesDeleteByID},
|
|
|
+ {"GetByID", loginSourcesGetByID},
|
|
|
+ {"List", loginSourcesList},
|
|
|
+ {"ResetNonDefault", loginSourcesResetNonDefault},
|
|
|
+ {"Save", loginSourcesSave},
|
|
|
} {
|
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
|
t.Cleanup(func() {
|
|
|
err := clearTables(t, db.DB, tables...)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ require.NoError(t, err)
|
|
|
})
|
|
|
tc.test(t, db)
|
|
|
})
|
|
|
@@ -116,62 +113,41 @@ func Test_loginSources(t *testing.T) {
|
|
|
}
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_Create(t *testing.T, db *loginSources) {
|
|
|
+func loginSourcesCreate(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
// Create first login source with name "GitHub"
|
|
|
- source, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Default: false,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
+ source, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Default: false,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Get it back and check the Created field
|
|
|
- source, err = db.GetByID(source.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source, err = db.GetByID(ctx, source.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Equal(t, db.NowFunc().Format(time.RFC3339), source.Created.UTC().Format(time.RFC3339))
|
|
|
assert.Equal(t, db.NowFunc().Format(time.RFC3339), source.Updated.UTC().Format(time.RFC3339))
|
|
|
|
|
|
// Try create second login source with same name should fail
|
|
|
- _, err = db.Create(CreateLoginSourceOpts{Name: source.Name})
|
|
|
+ _, err = db.Create(ctx, CreateLoginSourceOpts{Name: source.Name})
|
|
|
expErr := ErrLoginSourceAlreadyExist{args: errutil.Args{"name": source.Name}}
|
|
|
assert.Equal(t, expErr, err)
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_Count(t *testing.T, db *loginSources) {
|
|
|
- // Create two login sources, one in database and one as source file.
|
|
|
- _, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Default: false,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
- },
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
-
|
|
|
- setMockLoginSourceFilesStore(t, db, &mockLoginSourceFilesStore{
|
|
|
- MockLen: func() int {
|
|
|
- return 2
|
|
|
- },
|
|
|
- })
|
|
|
-
|
|
|
- assert.Equal(t, int64(3), db.Count())
|
|
|
-}
|
|
|
+func loginSourcesCount(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
|
|
|
-func test_loginSources_DeleteByID(t *testing.T, db *loginSources) {
|
|
|
- t.Run("delete but in used", func(t *testing.T) {
|
|
|
- source, err := db.Create(CreateLoginSourceOpts{
|
|
|
+ // Create two login sources, one in database and one as source file.
|
|
|
+ _, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
Type: auth.GitHub,
|
|
|
Name: "GitHub",
|
|
|
Activated: true,
|
|
|
@@ -179,279 +155,271 @@ func test_loginSources_DeleteByID(t *testing.T, db *loginSources) {
|
|
|
Config: &github.Config{
|
|
|
APIEndpoint: "https://api.github.com",
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ },
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
+
|
|
|
+ mock := NewMockLoginSourceFilesStore()
|
|
|
+ mock.LenFunc.SetDefaultReturn(2)
|
|
|
+ setMockLoginSourceFilesStore(t, db, mock)
|
|
|
+
|
|
|
+ assert.Equal(t, int64(3), db.Count(ctx))
|
|
|
+}
|
|
|
+
|
|
|
+func loginSourcesDeleteByID(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
+ t.Run("delete but in used", func(t *testing.T) {
|
|
|
+ source, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Default: false,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
+ },
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Create a user that uses this login source
|
|
|
_, err = (&users{DB: db.DB}).Create("alice", "", CreateUserOpts{
|
|
|
LoginSource: source.ID,
|
|
|
})
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Delete the login source will result in error
|
|
|
- err = db.DeleteByID(source.ID)
|
|
|
+ err = db.DeleteByID(ctx, source.ID)
|
|
|
expErr := ErrLoginSourceInUse{args: errutil.Args{"id": source.ID}}
|
|
|
assert.Equal(t, expErr, err)
|
|
|
})
|
|
|
|
|
|
- setMockLoginSourceFilesStore(t, db, &mockLoginSourceFilesStore{
|
|
|
- MockGetByID: func(id int64) (*LoginSource, error) {
|
|
|
- return nil, ErrLoginSourceNotExist{args: errutil.Args{"id": id}}
|
|
|
- },
|
|
|
+ mock := NewMockLoginSourceFilesStore()
|
|
|
+ mock.GetByIDFunc.SetDefaultHook(func(id int64) (*LoginSource, error) {
|
|
|
+ return nil, ErrLoginSourceNotExist{args: errutil.Args{"id": id}}
|
|
|
})
|
|
|
+ setMockLoginSourceFilesStore(t, db, mock)
|
|
|
|
|
|
// Create a login source with name "GitHub2"
|
|
|
- source, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub2",
|
|
|
- Activated: true,
|
|
|
- Default: false,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
+ source, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub2",
|
|
|
+ Activated: true,
|
|
|
+ Default: false,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Delete a non-existent ID is noop
|
|
|
- err = db.DeleteByID(9999)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ err = db.DeleteByID(ctx, 9999)
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// We should be able to get it back
|
|
|
- _, err = db.GetByID(source.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ _, err = db.GetByID(ctx, source.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Now delete this login source with ID
|
|
|
- err = db.DeleteByID(source.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ err = db.DeleteByID(ctx, source.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// We should get token not found error
|
|
|
- _, err = db.GetByID(source.ID)
|
|
|
+ _, err = db.GetByID(ctx, source.ID)
|
|
|
expErr := ErrLoginSourceNotExist{args: errutil.Args{"id": source.ID}}
|
|
|
assert.Equal(t, expErr, err)
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_GetByID(t *testing.T, db *loginSources) {
|
|
|
- setMockLoginSourceFilesStore(t, db, &mockLoginSourceFilesStore{
|
|
|
- MockGetByID: func(id int64) (*LoginSource, error) {
|
|
|
- if id != 101 {
|
|
|
- return nil, ErrLoginSourceNotExist{args: errutil.Args{"id": id}}
|
|
|
- }
|
|
|
- return &LoginSource{ID: id}, nil
|
|
|
- },
|
|
|
+func loginSourcesGetByID(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
+ mock := NewMockLoginSourceFilesStore()
|
|
|
+ mock.GetByIDFunc.SetDefaultHook(func(id int64) (*LoginSource, error) {
|
|
|
+ if id != 101 {
|
|
|
+ return nil, ErrLoginSourceNotExist{args: errutil.Args{"id": id}}
|
|
|
+ }
|
|
|
+ return &LoginSource{ID: id}, nil
|
|
|
})
|
|
|
+ setMockLoginSourceFilesStore(t, db, mock)
|
|
|
|
|
|
expConfig := &github.Config{
|
|
|
APIEndpoint: "https://api.github.com",
|
|
|
}
|
|
|
|
|
|
// Create a login source with name "GitHub"
|
|
|
- source, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Default: false,
|
|
|
- Config: expConfig,
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Default: false,
|
|
|
+ Config: expConfig,
|
|
|
+ },
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Get the one in the database and test the read/write hooks
|
|
|
- source, err = db.GetByID(source.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source, err = db.GetByID(ctx, source.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Equal(t, expConfig, source.Provider.Config())
|
|
|
|
|
|
// Get the one in source file store
|
|
|
- _, err = db.GetByID(101)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ _, err = db.GetByID(ctx, 101)
|
|
|
+ require.NoError(t, err)
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_List(t *testing.T, db *loginSources) {
|
|
|
- setMockLoginSourceFilesStore(t, db, &mockLoginSourceFilesStore{
|
|
|
- MockList: func(opts ListLoginSourceOpts) []*LoginSource {
|
|
|
- if opts.OnlyActivated {
|
|
|
- return []*LoginSource{
|
|
|
- {ID: 1},
|
|
|
- }
|
|
|
- }
|
|
|
+func loginSourcesList(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
+ mock := NewMockLoginSourceFilesStore()
|
|
|
+ mock.ListFunc.SetDefaultHook(func(opts ListLoginSourceOpts) []*LoginSource {
|
|
|
+ if opts.OnlyActivated {
|
|
|
return []*LoginSource{
|
|
|
{ID: 1},
|
|
|
- {ID: 2},
|
|
|
}
|
|
|
- },
|
|
|
+ }
|
|
|
+ return []*LoginSource{
|
|
|
+ {ID: 1},
|
|
|
+ {ID: 2},
|
|
|
+ }
|
|
|
})
|
|
|
+ setMockLoginSourceFilesStore(t, db, mock)
|
|
|
|
|
|
// Create two login sources in database, one activated and the other one not
|
|
|
- _, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.PAM,
|
|
|
- Name: "PAM",
|
|
|
- Config: &pam.Config{
|
|
|
- ServiceName: "PAM",
|
|
|
+ _, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.PAM,
|
|
|
+ Name: "PAM",
|
|
|
+ Config: &pam.Config{
|
|
|
+ ServiceName: "PAM",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
- _, err = db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
+ _, err = db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// List all login sources
|
|
|
- sources, err := db.List(ListLoginSourceOpts{})
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ sources, err := db.List(ctx, ListLoginSourceOpts{})
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Equal(t, 4, len(sources), "number of sources")
|
|
|
|
|
|
// Only list activated login sources
|
|
|
- sources, err = db.List(ListLoginSourceOpts{OnlyActivated: true})
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ sources, err = db.List(ctx, ListLoginSourceOpts{OnlyActivated: true})
|
|
|
+ require.NoError(t, err)
|
|
|
assert.Equal(t, 2, len(sources), "number of sources")
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_ResetNonDefault(t *testing.T, db *loginSources) {
|
|
|
- setMockLoginSourceFilesStore(t, db, &mockLoginSourceFilesStore{
|
|
|
- MockList: func(opts ListLoginSourceOpts) []*LoginSource {
|
|
|
- return []*LoginSource{
|
|
|
- {
|
|
|
- File: &mockLoginSourceFileStore{
|
|
|
- MockSetGeneral: func(name, value string) {
|
|
|
- assert.Equal(t, "is_default", name)
|
|
|
- assert.Equal(t, "false", value)
|
|
|
- },
|
|
|
- MockSave: func() error {
|
|
|
- return nil
|
|
|
- },
|
|
|
- },
|
|
|
- },
|
|
|
- }
|
|
|
- },
|
|
|
- MockUpdate: func(source *LoginSource) {},
|
|
|
+func loginSourcesResetNonDefault(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
+ mock := NewMockLoginSourceFilesStore()
|
|
|
+ mock.ListFunc.SetDefaultHook(func(opts ListLoginSourceOpts) []*LoginSource {
|
|
|
+ mockFile := NewMockLoginSourceFileStore()
|
|
|
+ mockFile.SetGeneralFunc.SetDefaultHook(func(name, value string) {
|
|
|
+ assert.Equal(t, "is_default", name)
|
|
|
+ assert.Equal(t, "false", value)
|
|
|
+ })
|
|
|
+ return []*LoginSource{
|
|
|
+ {
|
|
|
+ File: mockFile,
|
|
|
+ },
|
|
|
+ }
|
|
|
})
|
|
|
+ setMockLoginSourceFilesStore(t, db, mock)
|
|
|
|
|
|
// Create two login sources both have default on
|
|
|
- source1, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.PAM,
|
|
|
- Name: "PAM",
|
|
|
- Default: true,
|
|
|
- Config: &pam.Config{
|
|
|
- ServiceName: "PAM",
|
|
|
+ source1, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.PAM,
|
|
|
+ Name: "PAM",
|
|
|
+ Default: true,
|
|
|
+ Config: &pam.Config{
|
|
|
+ ServiceName: "PAM",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
- source2, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Default: true,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
+ source2, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Default: true,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Set source 1 as default
|
|
|
- err = db.ResetNonDefault(source1)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ err = db.ResetNonDefault(ctx, source1)
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
// Verify the default state
|
|
|
- source1, err = db.GetByID(source1.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source1, err = db.GetByID(ctx, source1.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
assert.True(t, source1.IsDefault)
|
|
|
|
|
|
- source2, err = db.GetByID(source2.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source2, err = db.GetByID(ctx, source2.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
assert.False(t, source2.IsDefault)
|
|
|
}
|
|
|
|
|
|
-func test_loginSources_Save(t *testing.T, db *loginSources) {
|
|
|
+func loginSourcesSave(t *testing.T, db *loginSources) {
|
|
|
+ ctx := context.Background()
|
|
|
+
|
|
|
t.Run("save to database", func(t *testing.T) {
|
|
|
// Create a login source with name "GitHub"
|
|
|
- source, err := db.Create(CreateLoginSourceOpts{
|
|
|
- Type: auth.GitHub,
|
|
|
- Name: "GitHub",
|
|
|
- Activated: true,
|
|
|
- Default: false,
|
|
|
- Config: &github.Config{
|
|
|
- APIEndpoint: "https://api.github.com",
|
|
|
+ source, err := db.Create(ctx,
|
|
|
+ CreateLoginSourceOpts{
|
|
|
+ Type: auth.GitHub,
|
|
|
+ Name: "GitHub",
|
|
|
+ Activated: true,
|
|
|
+ Default: false,
|
|
|
+ Config: &github.Config{
|
|
|
+ APIEndpoint: "https://api.github.com",
|
|
|
+ },
|
|
|
},
|
|
|
- })
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ )
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
source.IsActived = false
|
|
|
source.Provider = github.NewProvider(&github.Config{
|
|
|
APIEndpoint: "https://api2.github.com",
|
|
|
})
|
|
|
- err = db.Save(source)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ err = db.Save(ctx, source)
|
|
|
+ require.NoError(t, err)
|
|
|
|
|
|
- source, err = db.GetByID(source.ID)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
- }
|
|
|
+ source, err = db.GetByID(ctx, source.ID)
|
|
|
+ require.NoError(t, err)
|
|
|
assert.False(t, source.IsActived)
|
|
|
assert.Equal(t, "https://api2.github.com", source.GitHub().APIEndpoint)
|
|
|
})
|
|
|
|
|
|
t.Run("save to file", func(t *testing.T) {
|
|
|
- calledSave := false
|
|
|
+ mockFile := NewMockLoginSourceFileStore()
|
|
|
source := &LoginSource{
|
|
|
Provider: github.NewProvider(&github.Config{
|
|
|
APIEndpoint: "https://api.github.com",
|
|
|
}),
|
|
|
- File: &mockLoginSourceFileStore{
|
|
|
- MockSetGeneral: func(name, value string) {},
|
|
|
- MockSetConfig: func(cfg interface{}) error { return nil },
|
|
|
- MockSave: func() error {
|
|
|
- calledSave = true
|
|
|
- return nil
|
|
|
- },
|
|
|
- },
|
|
|
- }
|
|
|
- err := db.Save(source)
|
|
|
- if err != nil {
|
|
|
- t.Fatal(err)
|
|
|
+ File: mockFile,
|
|
|
}
|
|
|
- assert.True(t, calledSave)
|
|
|
+ err := db.Save(ctx, source)
|
|
|
+ require.NoError(t, err)
|
|
|
+ mockrequire.Called(t, mockFile.SaveFunc)
|
|
|
})
|
|
|
}
|
Joe Chen