Browse Source

fix Page bug

Looly 5 years ago
parent
commit
2b9fb67cd0

+ 1 - 0
CHANGELOG.md

@@ -13,6 +13,7 @@
 ### Bug修复
 * 【db     】     修复PageResult.isLast计算问题
 * 【cron   】     修复更改系统时间后CronTimer被阻塞的问题(issue#838@Github)
+* 【db     】     修复Page.addOrder无效问题(issue#838@Github)
 
 -------------------------------------------------------------------------------------------------------------
 ## 5.3.1 (2020-04-17)

+ 1 - 4
hutool-db/src/main/java/cn/hutool/db/Page.java

@@ -134,10 +134,7 @@ public class Page implements Serializable {
 	 * @param orders 排序
 	 */
 	public void addOrder(Order... orders) {
-		if (null != this.orders) {
-			ArrayUtil.append(this.orders, orders);
-		}
-		this.orders = orders;
+		this.orders = ArrayUtil.append(this.orders, orders);
 	}
 	// ---------------------------------------------------------- Getters and Setters end
 

+ 17 - 0
hutool-db/src/test/java/cn/hutool/db/PageTest.java

@@ -0,0 +1,17 @@
+package cn.hutool.db;
+
+import cn.hutool.db.sql.Order;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class PageTest {
+
+	@Test
+	public void addOrderTest() {
+		Page page = new Page();
+		page.addOrder(new Order("aaa"));
+		Assert.assertEquals(page.getOrders().length, 1);
+		page.addOrder(new Order("aaa"));
+		Assert.assertEquals(page.getOrders().length, 2);
+	}
+}