Browse Source

!175 座机号码TEL正则,应该使用常量
Merge pull request !175 from handy/v5-dev

Looly 5 years ago
parent
commit
56917f5295

+ 5 - 1
hutool-core/src/main/java/cn/hutool/core/img/Img.java

@@ -37,6 +37,7 @@ import java.io.File;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.Serializable;
+import java.math.BigDecimal;
 import java.net.URL;
 import java.nio.file.Path;
 
@@ -302,7 +303,10 @@ public class Img implements Serializable {
 		double heightRatio = NumberUtil.div(height, srcHeight);
 		double widthRatio = NumberUtil.div(width, srcWidth);
 
-		if (widthRatio == heightRatio) {
+		// 浮点数之间的等值判断,基本数据类型不能用==比较,包装数据类型不能用equals来判断。
+		BigDecimal heightRatioBigDecimal = new BigDecimal(heightRatio);
+		BigDecimal widthRatioBigDecimal = new BigDecimal(widthRatio);
+		if (heightRatioBigDecimal.compareTo(widthRatioBigDecimal) == 0) {
 			// 长宽都按照相同比例缩放时,返回缩放后的图片
 			scale(width, height);
 		} else if (widthRatio < heightRatio) {

+ 1 - 1
hutool-core/src/main/java/cn/hutool/core/util/PhoneUtil.java

@@ -17,7 +17,7 @@ public class PhoneUtil {
 	/**
 	 * 座机号码
 	 */
-	private static Pattern TEL = Pattern.compile("0\\d{2,3}-[1-9]\\d{6,7}");
+	private static final Pattern TEL = Pattern.compile("0\\d{2,3}-[1-9]\\d{6,7}");
 
 	/**
 	 * 验证是否为手机号码(中国)